On #import, raise an error if the index does not exists. #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Empact, blast from the past! :) Agreed, this is a good protection! Can you please sign the CLA so I can merge the patch? Can you please ping me if I forget again? |
|
@karmi Sure thing! Updating the PR now to start. |
This is to avoid the index being created based on the structure of the bulk import json. Extract #index_exists? to serve.
Empact
force-pushed
the
import-missing-index
branch
from
49143a2 to
ea355c0
Compare
|
Ok, should be good to go now. |
|
Thanks!, excellent patch, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid the index being created based on the structure of the bulk import json.
Extract
#index_exists?to serve.Inspired by #243.