Skip to content

Optional IDPATH for import rake task. #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

russ
Copy link

@russ russ commented May 5, 2014

This is in reference to issue #100

@karmi
Copy link
Contributor

karmi commented May 6, 2014

Hey, thanks!, though the proper way how to handle custom IDs is to make sure Model.primary_key is used, not Model.id -- please see the discussion in #100.

@russ
Copy link
Author

russ commented May 6, 2014

Still trying to get the tests to run on this one. If anyone has any insight, here is the error I'm getting right now.

bundle exec rake test:all
--------------------------------------------------------------------------------
cd elasticsearch-model && unset BUNDLE_GEMFILE && bundle exec rake test:unit
Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    kaminari (>= 0) ruby depends on
      actionpack (>= 3.0.0) ruby depends on
        activesupport (= 3.2.8) ruby

    activerecord (> 4.0) ruby depends on
      activesupport (4.0.4)

@russ
Copy link
Author

russ commented May 6, 2014

Ok. Got the test running, though I'm not sure what I did differently. No tests are breaking for this case.

@karmi
Copy link
Contributor

karmi commented Jul 31, 2014

@russ Sorry for losing focus on this issue. It seems like we agreed in #100 that #113 actually solved this issue, can we close this then?

@karmi karmi added the waiting label Jul 31, 2014
@russ
Copy link
Author

russ commented Jul 31, 2014

Not a problem. Yes, #113 took care of the problem. Thanks for the help.

On Jul 31, 2014, at 10:13 AM, Karel Minarik notifications@github.com wrote:

@russ Sorry for losing focus on this issue. It seems like we agreed in #100 that #113 actually solved this issue, can we close this then?


Reply to this email directly or view it on GitHub.

@karmi
Copy link
Contributor

karmi commented Jul 31, 2014

@russ Great!, thanks for the confirmation!

@karmi karmi closed this Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants