Skip to content

Elasticsearch persistence mapping example - set mapping for attribute twice? #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
twigbranch opened this issue Apr 22, 2015 · 1 comment
Closed

Elasticsearch persistence mapping example - set mapping for attribute twice? #374

twigbranch opened this issue Apr 22, 2015 · 1 comment

Comments

@twigbranch
Copy link

Why is the example setting the mapping for suggest_title twice?
Here:
https://github.com/elastic/elasticsearch-rails/blob/master/elasticsearch-persistence/examples/music/album.rb#L16

and here:
https://github.com/elastic/elasticsearch-rails/blob/master/elasticsearch-persistence/examples/music/album.rb#L25
@karmi
Copy link
Contributor

karmi commented Apr 22, 2015

I think it's merely an oversight, one of these is not needed...

dabit pushed a commit to dabit/elasticsearch-rails that referenced this issue Apr 23, 2015
[STORE] Fix duplicate attribute declaration in example
cda8318 
Fixes elastic#374
@dabit dabit mentioned this issue Apr 23, 2015
Closed
@karmi karmi closed this as completed in f5fc4ea Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[STORE] Fix duplicate attribute declaration in example dabit/elasticsearch-rails
2 participants
@karmi @twigbranch