Rails instrumentation does not work with persistence model

[trungpham]

class MyModel
  include Elasticsearch::Persistence::Model
end

I can't seem to get rails timing to work the standalone persistence model. Is it because I'm not using ActiveModel?

[karmi]

Can you provide more information and code, please? I don't have the bandwith to decipher what "get rails timing to work" can mean and try it on my own.

[trungpham]

I added require 'elasticsearch/rails/lograge' to application.rb,
but the elasticsearch_runtime value in the event object is always 0.

https://github.com/elasticsearch/elasticsearch-rails/blob/master/elasticsearch-rails/lib/elasticsearch/rails/lograge.rb#L25

[trungpham]

I think this is because I am not using MyModel.search method.
https://github.com/elasticsearch/elasticsearch-rails/blob/master/elasticsearch-rails/lib/elasticsearch/rails/instrumentation/publishers.rb#L18

I think I need to record the timing at the transport level. https://github.com/elasticsearch/elasticsearch-ruby/blob/master/elasticsearch-transport/lib/elasticsearch/transport/transport/base.rb#L228

[karmi]

Well, the persistence doesn't work with the "elasticsearch-persistence" gem, that would have to be added ...

UPDATE: the instrumentation of course...

[lorgio]

It looks like there's a difference between the way the persistence gem builds a query in the search method and the one used in elasticsearch-model .

The Instrumentation::Publishers chains to the execute! method, which the persistence-gem does not have.

In the persistence gem, the search method does a client.search call, while the elasticsearch-model creates a SearchRequest object.

[trungpham]

I think we should instrument the timing at the lowest level possible, so both elasticsearch-model and persistence gems can share them.

[karmi]

I'll have a look into that. I don't think we can re-use the searching code between model and persistence, but it would have been nice to have the instrumentation support for persistence of course.

[trungpham]

@karmi awesome!

[karmi]

@trungpham I've spent hours debugging the weird ways Rails calls initializers :), but the instrumentation should be working now. Verified in my own application using Persistence::Model.

There's a slight incovenience with Lograge, since it probably ignores any config.lograge.custom_options when not enabled. I've opened roidrage/lograge#89 for reference.

In the meantime, just copy&paste that code into your production.rb or something like that.

[Mathiou04]

Hi,
I am using elasticsearch-persistence (5.0.1) but cannot find a way to instrument it in my development environment.
I tried to require 'elasticsearch/rails/instrumentation' in my application.rb file but this does not seem to work as I do not see any more logs in my rails console.

I suppose I could make it work by overloading the client using option log: true in my model.
Actually I see the instrumentation logs when I instantiate a client:
Elasticsearch::Client.new(log: true).cluster.health
But is there a better way to turn it on once for all models ?