Skip to content

changes for ES 1.0 release #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cleesmith opened this issue Feb 12, 2014 · 4 comments
Closed

changes for ES 1.0 release #12

cleesmith opened this issue Feb 12, 2014 · 4 comments

Comments

@cleesmith
Copy link

This works great with es-ruby 0.4 but it is locked to that version.
What could I change to work with es-ruby 1.0.0 ?

@cleesmith
Copy link
Author

Nevermind ... I just forked and changed the gemspec dependency to '~> 1.0' and it works
fine, except all of the results fields are surrounded by double quotes/brackets like:

["some_data"]

Odd, it worked ok before, but I guess all fields are arrays now, so this works:

whatever.results.fields.some_field.first

@karmi
Copy link
Contributor

karmi commented Feb 12, 2014

@cleesmith Yeah, I need to update that dependency to '> 0.4', the fields have indeed changed, but only if you use fields -- http://www.elasticsearch.org/guide/en/elasticsearch/reference/master/search-request-source-filtering.html is now the recommended way.

@karmi karmi closed this as completed in fa71c29 Feb 12, 2014
@cleesmith
Copy link
Author

Thank you! That link was very helpful.
The code, gems, and so on surrounding elasticsearch are well done ... who
knew you could find joy in boring old log apps. A few fixes in Kibana and this
will all be great.

@karmi
Copy link
Contributor

karmi commented Feb 12, 2014

Cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants