Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.

Update Getting Started with Languages: #678

Merged
merged 2 commits into from
May 10, 2017
Merged

Update Getting Started with Languages: #678

merged 2 commits into from
May 10, 2017

Conversation

joshuar
Copy link
Contributor

@joshuar joshuar commented May 1, 2017

This fixes up the Getting Started with Languages section:

  • Remove O'Reilly index cruft
  • CONSOLE-ify code snippets
  • Fix deprecated Elasticsearch DSL syntax
  • Where possible, add example documents so mapping changes and searches
    can be properly observed
  • Fix line wraps
  • Remove mentions of document types

* Remove O'Reilly index cruft
* CONSOLE-ify code snippets
* Fix deprecated Elasticsearch DSL syntax
* Where possible, add example documents so mapping changes and searches
can be properly observed
* Fix line wraps
@joshuar joshuar requested review from debadair and polyfractal May 1, 2017 05:34
@@ -1,10 +1,10 @@
[[one-lang-docs]]
=== One Language per Document

A single predominant language per document ((("languages", "one language per document")))((("indices", "documents in different languages")))requires a relatively simple setup.
A single predominant language per document requires a relatively simple setup.
Documents from different languages can be stored in separate indices—`blogs-en`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clean up these — characters as well. Another artifact from O'Reilly, which unfortunately breaks AsciiDoctor because they don't support arbitrary character codes (see: http://discuss.asciidoctor.org/Can-I-build-this-https-github-com-elastic-elasticsearch-definitive-guide-into-pdf-td3845.html#a3854)

Em-dash is supported natively with "space dash-dash space" (--). Complete set of out of the box codes here: http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#attributes-and-substitutions

If we run into any non-predefined codes we can make some custom attributes. I'll send a mail about this for everyone else, forgot about this issue until now. :)

@polyfractal
Copy link
Contributor

LGTM! Left a minor comment about some character codes.

++ to all the CONSOLE'ifying!

@joshuar joshuar merged commit d8aed6c into elastic:master May 10, 2017
@joshuar joshuar deleted the fix_analyze_API_usage branch May 10, 2017 23:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants