Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-prioritize RCP tracepoints #20900

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Re-prioritize RCP tracepoints #20900

merged 1 commit into from
Jan 9, 2025

Conversation

tajila
Copy link
Contributor

@tajila tajila commented Jan 9, 2025

Currently, the tracepoints for RCP memory allocations and classloading are enabled by default. These are hot paths which means that we incur an overhead when writing out the tracepoints. Additionally, in a large app these tracepoints would dominate the trace output. For these reasons the tracepoint levels should be increased.

@tajila tajila requested a review from babsingh January 9, 2025 19:27
@tajila
Copy link
Contributor Author

tajila commented Jan 9, 2025

@babsingh Please review these changes

@babsingh
Copy link
Contributor

babsingh commented Jan 9, 2025

There is a typo in the commit message: pverhead -> overhead. Otherwise, LGTM.

Currently, the tracepoints for RCP memory allocations and classloading
are enabled by default. These are hot paths which means that we incur an
overhead when writing out the tracepoints. Additionally, in a large app
these tracepoints would dominate the trace output. For these reasons the
tracepoint levels should be increased.

Signed-off-by: tajila <atobia@ca.ibm.com>
@tajila
Copy link
Contributor Author

tajila commented Jan 9, 2025

Please take another look

@babsingh
Copy link
Contributor

babsingh commented Jan 9, 2025

jenkins compile amac jdk21

@babsingh babsingh merged commit 7c49319 into eclipse-openj9:master Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants