remove support for Python 2.7 and 3.5 #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
boegel
requested changes
Mar 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
boegel
requested changes
Apr 12, 2023
use log.deprecated in py2vs3 module
…s by importing from easybuild.base.wrapper in py2vs3/*.py
… imports in 3rd party code
boegel
requested changes
Apr 12, 2023
easybuild/tools/asyncprocess.py
Outdated
| @@ -152,6 +152,24 @@ def _recv(self, which, maxsize): | |||
| message = "Other end disconnected!" | |||
|
|
|||
|
|
|||
| def subprocess_popen_text(cmd, **kwargs): | |||
There was a problem hiding this comment.
I think easybuild.tools.run is a better place for this, see branfosj#8
| return metaclass(base_class_name, bases, {}) | ||
|
|
||
|
|
||
| def mk_wrapper_baseclass(metaclass): |
There was a problem hiding this comment.
@branfosj If we copy these functions here, we should also import them from easybuild.base.wrapper in py2vs3/py3.py, to avoid having two copies of them?
see branfosj#8
relocate subprocess_popen_text + subprocess_terminate to easybuild.tools.run, import create_base_metaclass + mk_wrapper_baseclass from easybuild.base.wrapper in py2vs3/*.py
boegel
changed the title
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for running EasyBuild on Python 2.x and 3.5.