Add quirk for missing space in continue req command

[soywod]

Fixes #638.

[coveralls]

Pull Request Test Coverage Report for Build 13673990768

Details

• 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 91.609%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
imap-codec/src/response.rs	6	9	66.67%

Totals
Change from base Build 13317192473:	-0.02%
Covered Lines:	11474
Relevant Lines:	12525

---

💛 - Coveralls

[duesee]

Hey, thanks for the PR! Somehow missed this one, sorry. Do we want to allow +<base64>\r\n, too? Or only an additional +\r\n?

[soywod]

This is a very good question. I would say we only encountered +\r\n at the moment, so let's be simple and just add a quirk for that use case. We can still extend the scope of this quirk later on.

---

Why GitHub complains about blocked merge?

This branch must not contain merge commits.

But this branch does only contain one simple commit…

[duesee]

Why GitHub complains about blocked merge?

Does it? I can click on Rebase and merge...

[soywod]

Strange… go ahead then if it's green from your side 👌

[duesee]

Weird... but do you want to adapt to only allow +/r/n then? If my reading is correct, we will allow +<stuff>\r\n after the merge? Because you said you would also prefer to have minimal quirks.

[soywod]

Oh I see what you mean. In my mind it was more "this PR only makes the space after + optional", but it turns out to accept +<any>\r\n. Only accepting +\r\n would make the PR more complicated, I like the simplicity of this one, but at the same time the scope is larger and conflicts with what I said last time. What's your opinion?

[duesee]

I would also prefer to have minimal quirks but would also merge as is when the alternative is more complicated. I'll let you decide if you want to give the more minimal approach a try or prefer to be quick here :-) We can also make a reminder to tighten up later if we feel like it. There should be no harm done either way.

[soywod]

I opted for the smaller scope. Ready for another review!

[duesee]

Less code and tighter! Awesome, thanks!