Skip to content

Conversation

@gkerenyi
Copy link
Contributor

@gkerenyi gkerenyi commented Nov 4, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209272522976873/task/1211160811951792?focus=true

Description

Enables the following sub-features of the sync feature for Windows users starting from v0.136.0:

  • syncCreditCards
  • syncIdentities

Note

Enables syncCreditCards and syncIdentities on Windows with minSupportedVersion 0.136.0.

  • Windows overrides (overrides/windows-override.json):
    • sync feature:
      • Enable syncCreditCards with minSupportedVersion 0.136.0.
      • Enable syncIdentities with minSupportedVersion 0.136.0.

Written by Cursor Bugbot for commit 6a16058. This will update automatically on new commits. Configure here.

@gkerenyi gkerenyi requested review from a team and daxtheduck as code owners November 4, 2025 14:09
github-actions bot pushed a commit that referenced this pull request Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Generated file outputs:

Time updated: Tue, 04 Nov 2025 14:22:27 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json

⚠️ File is identical

v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -96422,12 +96422,14 @@
                 "syncSetupBarcodeIsUrlBased": {
                     "state": "enabled"
                 },
                 "syncCreditCards": {
-                    "state": "disabled"
+                    "state": "enabled",
+                    "minSupportedVersion": "0.136.0"
                 },
                 "syncIdentities": {
-                    "state": "disabled"
+                    "state": "enabled",
+                    "minSupportedVersion": "0.136.0"
                 },
                 "seamlessAccountSwitching": {
                     "state": "enabled"
                 }
v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -95862,12 +95862,14 @@
                 "syncSetupBarcodeIsUrlBased": {
                     "state": "enabled"
                 },
                 "syncCreditCards": {
-                    "state": "internal"
+                    "state": "enabled",
+                    "minSupportedVersion": "0.136.0"
                 },
                 "syncIdentities": {
-                    "state": "internal"
+                    "state": "enabled",
+                    "minSupportedVersion": "0.136.0"
                 },
                 "seamlessAccountSwitching": {
                     "state": "enabled"
                 }
latest
13 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json

⚠️ File is identical

v5/windows-config.json
--- v5/windows-config.json
+++ v5/windows-config.json
@@ -95862,12 +95862,14 @@
                 "syncSetupBarcodeIsUrlBased": {
                     "state": "enabled"
                 },
                 "syncCreditCards": {
-                    "state": "internal"
+                    "state": "enabled",
+                    "minSupportedVersion": "0.136.0"
                 },
                 "syncIdentities": {
-                    "state": "internal"
+                    "state": "enabled",
+                    "minSupportedVersion": "0.136.0"
                 },
                 "seamlessAccountSwitching": {
                     "state": "enabled"
                 }

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

JSON approval analysis:

Time updated: Tue, 04 Nov 2025 14:22:35 GMT

legacy

❌ Manual Review Required

  • v3/windows-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/sync/features/syncIdentities/state (replace)
    • /features/sync/features/syncIdentities/minSupportedVersion (add)
    • /features/sync/features/syncCreditCards/state (replace)
    • /features/sync/features/syncCreditCards/minSupportedVersion (add)
  • v4/windows-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/sync/features/syncIdentities/state (replace)
    • /features/sync/features/syncIdentities/minSupportedVersion (add)
    • /features/sync/features/syncCreditCards/state (replace)
    • /features/sync/features/syncCreditCards/minSupportedVersion (add)
latest

❌ Manual Review Required

  • v5/windows-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/sync/features/syncIdentities/state (replace)
    • /features/sync/features/syncIdentities/minSupportedVersion (add)
    • /features/sync/features/syncCreditCards/state (replace)
    • /features/sync/features/syncCreditCards/minSupportedVersion (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

@gkerenyi gkerenyi added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 1ba758b Nov 4, 2025
16 of 23 checks passed
@gkerenyi gkerenyi deleted the gabor/windows-enable-cc-id-sync branch November 4, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants