Skip to content

Conversation

@mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Jun 6, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1203249713006009/task/1210483318529990?focus=true

Description

  • Added a new youtubeErrorSelector property to the custom error settings for Duck Player on all platforms. This will potentially allow a faster response in case YouTube changes how they render playback errors.

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@github-actions
Copy link

github-actions bot commented Jun 6, 2025

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

github-actions bot pushed a commit that referenced this pull request Jun 6, 2025
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

Generated file outputs:

Time updated: Fri, 06 Jun 2025 09:20:00 GMT

legacy
trackers-unprotected-temporary.txt (10 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json

⚠️ File is identical

v3/android-config.json (3 more)
  • v3/android-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -13581,9 +13581,10 @@
                 },
                 "customError": {
                     "state": "enabled",
                     "settings": {
-                        "signInRequiredSelector": "[href*=\"//support.google.com/youtube/answer/3037019\"]"
+                        "signInRequiredSelector": "[href*=\"//support.google.com/youtube/answer/3037019\"]",
+                        "youtubeErrorSelector": ".ytp-error"
                     }
                 },
                 "nativeUI": {
                     "state": "disabled"
latest
v4/android-config.json (3 more)
  • v4/android-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -13183,9 +13183,10 @@
                 },
                 "customError": {
                     "state": "enabled",
                     "settings": {
-                        "signInRequiredSelector": "[href*=\"//support.google.com/youtube/answer/3037019\"]"
+                        "signInRequiredSelector": "[href*=\"//support.google.com/youtube/answer/3037019\"]",
+                        "youtubeErrorSelector": ".ytp-error"
                     }
                 },
                 "nativeUI": {
                     "state": "disabled"
v4/extension-brave-config.json (9 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json

⚠️ File is identical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant