This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Add missing next and previous find-in-page button handlers #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistairjcbrown
deleted the
abrown/bugfix-add-missing-find-in-page-handlers
branch
samsymons
added a commit
that referenced
this pull request
Nov 26, 2021
* develop: Address Bar visual tweaks (#310) Bump find-in-page to latest version (#352) Bump privacy dashboard to latest version (#349) fix popover message bug (#348) Add missing next and previous find-in-page button handlers (#351) add asserts to check that atb and install date are nil before being set (#350) copy private email address (#344) Reset tracker info on page change (#335) remove history menu and re-home other items (#343)
samsymons
added a commit
that referenced
this pull request
Dec 6, 2021
# By Alistair Brown (9) and others # Via GitHub * develop: (36 commits) Partial tech debt cleanup (#345) Address Bar visual tweaks (#310) Bump find-in-page to latest version (#352) Bump privacy dashboard to latest version (#349) fix popover message bug (#348) Add missing next and previous find-in-page button handlers (#351) add asserts to check that atb and install date are nil before being set (#350) copy private email address (#344) Reset tracker info on page change (#335) remove history menu and re-home other items (#343) Update the credit card model + UI tweaks (#342) 0.17.6 Add Usage Pixel (#336) Bump find-in-page to latest version (#337) Forward delete collision with suffix resolved (#334) Avoid using a specific browser as the default. (#341) Closing animation duration changed to 0.15 (#333) Hiding the favicon view when favicon is nil (#326) export bookmarks (#339) Ensure ITP database is cleared (#328) ... # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Tech Design URL:
CC: @brindy
Description:
Previous and next buttons for find-in-page aren't working after #331 -- adding in the handlers referenced in the storyboard
Steps to test this PR:
There's three ways to trigger next/previous for find-in-page -- confirm they all work as expected:
Enter / Shift+Enter
Next / Previous buttons
Cmd+G / Shift+Cmd+G keyboard shortcupts
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM