-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This reverts commit 8da65d2.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @ayoy. I tested different flows and re-sizing the window, and it looks great.
DuckDuckGo/Localizable.xcstrings
Outdated
@@ -35109,6 +35109,18 @@ | |||
} | |||
} | |||
}, | |||
"newTab.menu.item.show.search.bar" : { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Were these translations uploaded to Smartling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they weren't. I'll have one more small-ish PR with another piece of copy and will request translation once the copy review is done. I will only merge it when we have translations anyway.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208262570807667/f Description: This change adds pixels for tracking NTP Search Box experiment.
Task/Issue URL: https://app.asana.com/0/0/1208583505730578/f Description: This change adds a popover that is displayed once for every user over the 'Customize' button on the NTP. It's not a part of the experiment nor it's related to the search bar project. We're adding the onboarding to increase engagement with NTP customization settings.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208262951113965/f
Description:
This change introduces alternative New Tab Page UI including a search bar.
The new UI exists alongside the original UI and will be enabled to some users as an experiment.
The NTP search bar reuses existing AddressBarTextField wrapped in an NSViewRepresentable.
There's AddressBarViewModel class created for interacting with SwiftUI views - it encapsulates
AddressBarViewController and forwards actions to it.
NTP content with search bar is now centered vertically in the view if all NTP sections are hidden
or in collapsed state.
This code is meant to be temporary and will be removed after the experiment finishes.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation