This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Subscription refactoring 4 #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…Mock, AppStoreAccountManagementFlowMock
# Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Tab/UserScripts/Subscription/SubscriptionAppStoreRestorer.swift # DuckDuckGo/Tab/UserScripts/Subscription/SubscriptionPagesUserScript.swift # DuckDuckGo/Tab/UserScripts/UserScripts.swift
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
miasma13
reviewed
Jun 20, 2024
DuckDuckGo/Subscription/SubscriptionManager+StandardConfiguration.swift
Outdated
Show resolved
Hide resolved
Merge branch 'main' into fcappelli/subscription_refactoring_4 # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
miasma13
reviewed
Jun 24, 2024
DuckDuckGo/Tab/UserScripts/Subscription/SubscriptionAppStoreRestorer.swift
Show resolved
Hide resolved
miasma13
reviewed
Jun 24, 2024
DuckDuckGo/Tab/UserScripts/Subscription/SubscriptionPagesUserScript.swift
Outdated
Show resolved
Hide resolved
miasma13
reviewed
Jun 24, 2024
DuckDuckGo/Tab/UserScripts/Subscription/SubscriptionPagesUserScript.swift
Show resolved
Hide resolved
miasma13
approved these changes
Jun 24, 2024
miasma13
approved these changes
Jun 24, 2024
federicocappelli
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jun 24, 2024
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206805455884775/f iOS PR: duckduckgo/iOS#2961 macOS PR: duckduckgo/macos-browser#2871 What kind of version bump will this require?: Major **Description**: - Subscription API services and flows abstracted using protocols - Mocks created for all protocols **Mocks:** APIServiceMock AuthAPIServiceMock StorePurchaseManagerMock SubscriptionAPIServiceMock AccountKeychainStorageMock SubscriptionTokenKeychainStorageMock SubscriptionUIHandlerMock StripePurchaseFlowMock AppStoreRestoreFlowMock AppStorePurchaseFlowMock AppStoreAccountManagementFlowMock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206805455884775/f
CC: @miasma13
Description:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation