This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Replace old privacy page with new - MacOS #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afterxleep
requested review from
a team and
jaceklyp
and removed request for
a team
KeaganJarvis
reviewed
Sep 8, 2023
|
@KeaganJarvis mentioned we may have a test failing because site might is offline. We'll need to re-run the jobs once everything is up. |
# Conflicts: # DuckDuckGo/ContentBlocker/AppPrivacyConfigurationDataProvider.swift # DuckDuckGo/ContentBlocker/macos-config.json
jaceklyp
reviewed
Sep 27, 2023
| @@ -3,7 +3,7 @@ | |||
| set -eo pipefail | |||
|
|
|||
| TDS_URL="https://staticcdn.duckduckgo.com/trackerblocking/v5/current/macos-tds.json" | |||
| CONFIG_URL="https://staticcdn.duckduckgo.com/trackerblocking/config/v2/macos-config.json" | |||
| CONFIG_URL="https://staticcdn.duckduckgo.com/trackerblocking/config/v3/macos-config.json" | |||
There was a problem hiding this comment.
yes, it was updated in the code, but forgot to get updated here
samsymons
added a commit
that referenced
this pull request
Sep 27, 2023
…-remote-fetching * develop: Encapsulate handling one profile at the Repository level (#1676) Refactor MouseOverView/Button; fix bkm bar hlight glitch (#1667) Replace old privacy page with new - MacOS (#1611) Fix SwiftLint 0.53.0 warnings (#1683) fix crash in address bar selection macOS 12 (#1679) Fix of tab bar gap in Xcode 15 (#1680) Pixel m_mac_user_has_pinned_tab removed (#1675) Upload .xcresult artifacts on PR test failure (#1678) Prevent preferredRunDate from being set in the future (#1670) Fix Microsoft teams links opening in macOS browser (#1669) Bump version to 1.58.0 (61) Update embedded files Add underlying error info to the config fetch error (#1672)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:https://app.asana.com/0/72649045549333/1205442219109576/f
Description:
For DNS changes required we need to change our use of privacy-test-pages.glitch.me in integration tests to privacy-test-pages.site
Date is set for end of this week to try and take advantage of QWD, feel free to push it to later next week if necessary.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation