Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Oct 17, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1211383639881300?focus=true

Description

Disable features we don't use.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Conditionally include metaDescription, headings, links, and images in collected page content only when corresponding feature flags are enabled.

  • Page content collection (injected/src/features/page-context.js):
    • Gate optional fields via feature flags (default disabled):
      • includeMetaDescription → adds metaDescription
      • includeHeadings → adds headings
      • includeLinks → adds links
      • includeImages → adds images
    • Core fields unchanged: favicon, title, content, truncated, fullContentLength, timestamp, url.

Written by Cursor Bugbot for commit 7230c5f. This will update automatically on new commits. Configure here.

@netlify
Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 7230c5f
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68f25bde2e91100008a1cc28
😎 Deploy Preview https://deploy-preview-2018--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

[Beta] Generated file diff

Time updated: Fri, 17 Oct 2025 15:13:47 GMT

Apple
    - apple/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review October 17, 2025 15:11
@jonathanKingston jonathanKingston requested review from a team and noisysocks as code owners October 17, 2025 15:11
Copy link
Contributor

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Doesn’t hurt to have it.

@jonathanKingston jonathanKingston added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 91171f0 Oct 22, 2025
25 checks passed
@jonathanKingston jonathanKingston deleted the jkt/disable-page-collect-supplementary branch October 22, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants