Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Aug 20, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1211025695423965?focus=true

Description

  • Adds default enabled settings.
  • Allows features to be disabled with additionalCheck which means we can conditionally disable them per injectName, domain, experiment etc.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@netlify
Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 117e72a
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68a611c16041bb00088ea81a
😎 Deploy Preview https://deploy-preview-1908--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Aug 20, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Aug 20, 2025

[Beta] Generated file diff

Time updated: Wed, 20 Aug 2025 18:20:42 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Apple
    - apple/contentScope.js
  • apple/contentScopeIsolated.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston force-pushed the jkt/additionalCheckAndroid branch from b77512c to 1ba8af3 Compare August 20, 2025 14:36
@jonathanKingston jonathanKingston marked this pull request as ready for review August 20, 2025 17:32
@jonathanKingston jonathanKingston requested a review from a team as a code owner August 20, 2025 17:32
cursor[bot]

This comment was marked as outdated.

@jonathanKingston jonathanKingston added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit 3819168 Aug 21, 2025
18 checks passed
@jonathanKingston jonathanKingston deleted the jkt/additionalCheckAndroid branch August 21, 2025 08:37
jonathanKingston added a commit that referenced this pull request Aug 21, 2025
* Add additionalCheck for android rollout

* Add test case

* Simplify test case

* Lint fix

* Continue in the loop instead of return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants