Skip to content

Conversation

@noisysocks
Copy link
Contributor

@noisysocks noisysocks commented Jul 28, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210863200373708?focus=true

Description

Improve TabSwitcher hover interactions and visual design by fixing dead click areas, adding a 2px gap, and implementing a hover effects.

Testing Steps

  1. Browse to https://deploy-preview-1853--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar=true
  2. Hover over tab buttons and check there’s a hover effects
  3. Click anywhere on tab buttons including corners to verify there’s no dead click area
  4. Verify selected tabs do not show hover effects
  5. Check that 2px gap appears between tabs
  6. Test in both light and dark themes

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

- Add 2px gap between tabs for better visual separation
- Fix dead click areas by removing border-radius from base button styling
- Add hover state with background color and rounded corners using pseudo-element
- Prevent selected tab from showing hover effects
- Add pointer cursor on hover for better UX

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@noisysocks noisysocks requested review from a team, mgurgel and shakyShane as code owners July 28, 2025 05:08
@github-actions
Copy link

github-actions bot commented Jul 28, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@netlify
Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 48881c9
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6887300670061b0008c1714a
😎 Deploy Preview https://deploy-preview-1853--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Jul 28, 2025

[Beta] Generated file diff

Time updated: Mon, 28 Jul 2025 08:09:37 GMT

Integration
    - integration/pages/new-tab/dist/index.css

File has changed

Windows
    - windows/pages/new-tab/dist/index.css

File has changed

Apple
    - dist/pages/new-tab/dist/index.css

File has changed

@noisysocks noisysocks added the enhancement New feature or request label Jul 28, 2025
Update blob translate and width calculations to properly handle the 2px gap
between tabs, ensuring the blob stays aligned with the selected tab.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@noisysocks
Copy link
Contributor Author

Tested in macOS and Windows 👍

@noisysocks noisysocks changed the title Improve TabSwitcher hover interactions and visual design NTP: Improve TabSwitcher hover interactions and visual design Jul 28, 2025
@noisysocks noisysocks merged commit 855ae4f into main Jul 28, 2025
15 checks passed
@noisysocks noisysocks deleted the randerson/omnibar-tab-switcher-hover-improvements branch July 28, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants