Skip to content

Conversation

@dharb
Copy link
Contributor

@dharb dharb commented Jun 18, 2025

Asana Task/Github Issue:

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@dharb dharb requested a review from a team as a code owner June 18, 2025 19:19
@netlify
Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit e29f484
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68b0d74c5328ca00081c0a74
😎 Deploy Preview https://deploy-preview-1757--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Jun 18, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Jun 18, 2025

[Beta] Generated file diff

Time updated: Thu, 28 Aug 2025 22:26:10 GMT

Apple
    - apple/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed


const test = testContextForExtension(base);

test.describe('Scriptlets Integration Tests', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is all this a dupe of the test-pages stuff? I see a lot of waitForTimeout too which is pretty flakey.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it's supposed to be testing them. it seems a lot more involved than the intent here. Can you ask it to make this file more like injected/integration-test/pages.spec.js where there's no state where possible this will make most of them work in privacy-test-pages.site without having special setup code?

I also don't see it using the config in automation? Perhaps I've misread?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


<p>This page verifies that the remove-node-text scriptlet works properly given the <a href="../config/remove-node-text.json">config</a>.</p>

<!-- This script should have its content removed because it contains "badScriptContent" -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this test just be checking for regular div text change removal? Given the abort inline script it seems a little misleading as a test?

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants