Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose xhr.withCredentials with correct default #96

Merged
merged 1 commit into from
Oct 11, 2015

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Jan 19, 2015

Fixes #71
Replaces #84

@novabyte
Copy link

+1 can we merge this in please.

@kumavis
Copy link
Contributor Author

kumavis commented Mar 14, 2015

re-reviewed my code change, and all seems good. this is the correct default behavior for XHRs in the browser. ready to merge.

@novabyte
Copy link

@kumavis Thanks for re-checking it. I just stumbled across this problem in jsdom with a AJAX library I'm using in some headless test cases. The AJAX library detects support for CORS requests with:

var cors = 'withCredentials' in tmpxhr;

This fails at the moment in jsdom (3.*) because the withCredentials property is not on the XMLHttpRequest object...

@novabyte
Copy link

@driverdan Please can you merge this into master and build a new release.

@kumavis
Copy link
Contributor Author

kumavis commented Mar 25, 2015

📲 come on dan drive it home 🚙

@mareksuscak
Copy link

Can we merge this thing @driverdan?

@mareksuscak
Copy link

@novabyte for working XHR in jsdom you can use my patch https://github.com/mareksuscak/jsdom-xhr-patch until this gets resolved and merged.

driverdan added a commit that referenced this pull request Oct 11, 2015
Expose xhr.withCredentials with correct default
@driverdan driverdan merged commit 078626a into driverdan:master Oct 11, 2015
@kumavis
Copy link
Contributor Author

kumavis commented Oct 15, 2015

HE LIVES 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to define withCredentials
4 participants