-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add php solution to lc problem: No.0100 #932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangFong
requested changes
Mar 14, 2023
已修改 下次同类型问题要好好注意 |
YangFong
requested changes
Mar 15, 2023
Comment on lines
27
to
30
if ($p -> val != $q -> val) { | ||
return false; | ||
} | ||
return $this -> isSameTree($p -> left, $q -> left) && $this -> isSameTree($p -> right, $q -> right); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
虽然支持 $this -> propsName
这种写法,但推荐使用 $this->propsName
形式(箭头左右不加空白,可参考该文件 8~10 行注释)。
Suggested change
if ($p -> val != $q -> val) { | |
return false; | |
} | |
return $this -> isSameTree($p -> left, $q -> left) && $this -> isSameTree($p -> right, $q -> right); | |
if ($p->val != $q->val) { | |
return false; | |
} | |
return $this->isSameTree($p->left, $q->left) && $this->isSameTree($p->right, $q->right); |
回复晚了 谢谢你的提醒 |
yanglbme
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
第100题 php解法 谢谢