Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add php solution to lc problem: No.0303 #916

Merged
merged 6 commits into from
Mar 6, 2023
Merged

Conversation

Qiu-IT
Copy link
Member

@Qiu-IT Qiu-IT commented Mar 5, 2023

第303题 php方法修改 谢谢您们的提醒我做题的错误

@yanglbme
Copy link
Member

yanglbme commented Mar 6, 2023

这份代码直接在 leetcode 运行,会报“执行错误”,我稍微改一下

@yanglbme
Copy link
Member

yanglbme commented Mar 6, 2023

而且,README 中的代码块,需要标识对应的编程语言 ```php

@Qiu-IT
Copy link
Member Author

Qiu-IT commented Mar 6, 2023

谢谢您们的包容 这份PHP代码我还是没有处理好 这个合并给您们带来更多的额外工作
之前的代码在力扣跑了通过才敢上传的 但一定是我拷贝或者哪个位置都没有做对给您们添了麻烦 我会再去查查我代码的问题 再次的感谢

@Qiu-IT
Copy link
Member Author

Qiu-IT commented Mar 6, 2023

$this->nums = $nums 是多余的 昨天我commit完之后发现了这个问题 但我见力扣当时也给我通过就没有理会 很抱歉代码的不严谨给您们带来麻烦也容易误导后面学习的程序员 再次感谢您们的包容

@yanglbme
Copy link
Member

yanglbme commented Mar 6, 2023

@Qiu-IT 没事儿,小问题,下次尽量确保没啥问题再提交 pull request

@YangFong
Copy link
Member

YangFong commented Mar 6, 2023

之前所提供的格式化站点有问题,它并不支持新版本的 PHP 写法,将 -> 变成了 - >,导致不可用。

晚些时候,我看看 VSCode 如何配置吧。

@Qiu-IT
Copy link
Member Author

Qiu-IT commented Mar 6, 2023

之前所提供的格式化站点有问题,它并不支持新版本的 PHP 写法,将 -> 变成了 - >,导致不可用。

晚些时候,我看看 VSCode 如何配置吧。

啊 原来这个情况 谢谢啊 这样明白了一些情况了

@Qiu-IT Qiu-IT deleted the s0303 branch March 6, 2023 15:11
@YangFong
Copy link
Member

YangFong commented Mar 7, 2023

@Qiu-IT 似乎不需要什么额外配置,使用语言默认格式化,就够用了。

动画

@Qiu-IT
Copy link
Member Author

Qiu-IT commented Mar 10, 2023

太感谢了 之前都是用Notepad++
VScode 都是做JS和node.js 多
好的 小弟也尝试用VS code来写PHP了 谢谢您 杨大大

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants