Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a JS solution of 189 #712

Merged
merged 7 commits into from
Feb 11, 2022
Merged

feat: add a JS solution of 189 #712

merged 7 commits into from
Feb 11, 2022

Conversation

KimYangOfCat
Copy link
Member

参考 #710 的意见,重新提交,请不吝指出任何不规范之处

@KimYangOfCat KimYangOfCat changed the title feat: add one JS solution of 189 feat: add a JS solution of 189 Feb 11, 2022
Copy link
Member

@yanglbme yanglbme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README, README_EN 中已有 JavaScript 这个三级标题,所以这里不必重复添加。

image

@KimYangOfCat
Copy link
Member Author

明白了,抱歉

@yanglbme
Copy link
Member

代码的格式也需要调整,比如这段代码:

 var rotate = function(nums, k) {
    k%=nums.length;
    reverse(nums,0,nums.length-1);
    reverse(nums,0,k-1);
    reverse(nums,k,nums.length-1);
};

需要改成:

var rotate = function(nums, k) {
    k %= nums.length;
    reverse(nums, 0, nums.length - 1);
    reverse(nums, 0, k - 1);
    reverse(nums, k, nums.length - 1);
};

空格,缩进等。

Comment on lines 147 to 162
var rotate = function(nums, k) {
k %= nums.length;
// 使用三次数组翻转
reverse(nums, 0, nums.length-1);
reverse(nums, 0, k-1);
reverse(nums, k, nums.length-1);

};
function reverse(nums, start, end){
while(start < end){
const temp = nums[start];
nums[start] = nums[end];
nums[end] = temp;
start += 1;
end -= 1;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var rotate = function(nums, k) {
k %= nums.length;
// 使用三次数组翻转
reverse(nums, 0, nums.length-1);
reverse(nums, 0, k-1);
reverse(nums, k, nums.length-1);
};
function reverse(nums, start, end){
while(start < end){
const temp = nums[start];
nums[start] = nums[end];
nums[end] = temp;
start += 1;
end -= 1;
}
var rotate = function(nums, k) {
k %= nums.length;
// 使用三次数组翻转
reverse(nums, 0, nums.length - 1);
reverse(nums, 0, k - 1);
reverse(nums, k, nums.length - 1);
};
function reverse(nums, start, end) {
while (start < end) {
const temp = nums[start];
nums[start] = nums[end];
nums[end] = temp;
start += 1;
end -= 1;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也需要改一下哈 @KimYangOfCat

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README_EN.md 同

@yanglbme yanglbme merged commit 73b8655 into doocs:main Feb 11, 2022
@yanglbme
Copy link
Member

已合并,感谢参与项目,期待你更多的 pr 哈

@KimYangOfCat
Copy link
Member Author

很少手动格式化代码(使用工具居多),对很多代码格式不太熟悉,抱歉,给你添麻烦了,

感谢你的指导,基本清楚了需要注意的地方,后续会注意哒,

不过感觉这样手动格式化代码,你们的校对工作量好大呀,辛苦了!

有空的时候,我可以研究一下是否可以使用CLI的方式自动格式化代码,方便减轻你们的工作量

@yanglbme
Copy link
Member

可以配置 github actions 自动格式化代码,不过会产生新的 commit。

我目前倾向于每个人提交代码的时候,自己保证代码格式是 ok 的。

@KimYangOfCat
Copy link
Member Author

那真是辛苦了,感谢你的付出,点赞

@YangFong
Copy link
Member

很少手动格式化代码(使用工具居多),对很多代码格式不太熟悉,抱歉,给你添麻烦了,

感谢你的指导,基本清楚了需要注意的地方,后续会注意哒,

不过感觉这样手动格式化代码,你们的校对工作量好大呀,辛苦了!

有空的时候,我可以研究一下是否可以使用CLI的方式自动格式化代码,方便减轻你们的工作量

对于格式化,项目中添加了 prettier,大多数 IDE 都集成了配套插件。
我个人在完成书写后,便会对代码格式化一次,可以确保代码的格式正确。

@yanglbme
Copy link
Member

是的,项目中有 prettier 相关配置,可以统一格式。

只需要在 VSCode 等编辑器中安装 prettier 插件进行格式化即可。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants