Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the built-in slices.Min/Max functions in Go 1.21.0+ #1936

Merged
merged 1 commit into from
Nov 7, 2023
Merged

feat: use the built-in slices.Min/Max functions in Go 1.21.0+ #1936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions lcp/LCP 34. 二叉树染色/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,25 +172,15 @@ func maxValue(root *TreeNode, k int) int {
}
l := dfs(node.Left)
r := dfs(node.Right)
ans[0] = max(l...) + max(r...)
ans[0] = slices.Max(l) + slices.Max(r)
for i := 0; i < k; i++ {
for j := 0; j < k-i; j++ {
ans[i+j+1] = max(ans[i+j+1], l[i]+r[j]+node.Val)
}
}
return ans
}
return max(dfs(root)...)
}

func max(nums ...int) int {
ans := nums[0]
for _, x := range nums {
if x > ans {
ans = x
}
}
return ans
return slices.Max(dfs(root))
}
```

Expand Down
14 changes: 2 additions & 12 deletions lcp/LCP 34. 二叉树染色/Solution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,13 @@ func maxValue(root *TreeNode, k int) int {
}
l := dfs(node.Left)
r := dfs(node.Right)
ans[0] = max(l...) + max(r...)
ans[0] = slices.Max(l) + slices.Max(r)
for i := 0; i < k; i++ {
for j := 0; j < k-i; j++ {
ans[i+j+1] = max(ans[i+j+1], l[i]+r[j]+node.Val)
}
}
return ans
}
return max(dfs(root)...)
}

func max(nums ...int) int {
ans := nums[0]
for _, x := range nums {
if x > ans {
ans = x
}
}
return ans
return slices.Max(dfs(root))
}
12 changes: 1 addition & 11 deletions solution/1700-1799/1787.Make the XOR of All Segments Equal to Zero/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func minChanges(nums []int, k int) int {
}
for i, sz := range size {
g := make([]int, n)
x := min(f...) + sz
x := slices.Min(f) + sz
for i := range g {
g[i] = x
}
Expand All @@ -209,16 +209,6 @@ func minChanges(nums []int, k int) int {
}
return f[0]
}

func min(a ...int) int {
mi := a[0]
for _, v := range a {
if mi > v {
mi = v
}
}
return mi
}
```

### **...**
Expand Down
12 changes: 1 addition & 11 deletions solution/1700-1799/1787.Make the XOR of All Segments Equal to Zero/README_EN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func minChanges(nums []int, k int) int {
}
for i, sz := range size {
g := make([]int, n)
x := min(f...) + sz
x := slices.Min(f) + sz
for i := range g {
g[i] = x
}
Expand All @@ -171,16 +171,6 @@ func minChanges(nums []int, k int) int {
}
return f[0]
}

func min(a ...int) int {
mi := a[0]
for _, v := range a {
if mi > v {
mi = v
}
}
return mi
}
```

### **...**
Expand Down
12 changes: 1 addition & 11 deletions solution/1700-1799/1787.Make the XOR of All Segments Equal to Zero/Solution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func minChanges(nums []int, k int) int {
}
for i, sz := range size {
g := make([]int, n)
x := min(f...) + sz
x := slices.Min(f) + sz
for i := range g {
g[i] = x
}
Expand All @@ -27,14 +27,4 @@ func minChanges(nums []int, k int) int {
f = g
}
return f[0]
}

func min(a ...int) int {
mi := a[0]
for _, v := range a {
if mi > v {
mi = v
}
}
return mi
}