-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update rust solution to lc problem: No.0055 #1609
Conversation
🤭 感谢你的提交,请检查你的改动是否符合以下项目规范。 1. 格式化我们项目中各种编程语言代码(包括文档)所采用的格式化工具不同,提交 pr 之前必须确保代码、文档正确格式化。
2. Git 提交信息我们项目遵循 AngularJS Git Commit Message Conventions 规范,我们希望你的提交信息尽可能与项目保持一致。
3. 其它补充新增题解及代码时,需要创建 Solution.xxx 源代码文件(如果已存在,请确认算法是否更优,是则覆盖已有算法代码),同时,需要在 README.md 以及 README_EN.md 中添加对应的代码片段(英文文件中不要出现中文注释) 另外,编码风格(比如变量、函数的命名),尽量跟项目已有代码保持一致。 🤭 Thank you for your contribution. Please check if your changes comply with the following project specifications. 1. FormattingWe use different formatting tools for various programming languages (including documentation) in our project. You must ensure that the code and documentation are correctly formatted before submitting a pr.
2. Git Commit MessageOur project follows the AngularJS Git Commit Message Conventions. We hope that your submission information is as consistent as possible with the project.
3. Other notesWhen adding solutions and code, you need to create a Solution.xxx source code file (if it already exists, please confirm whether the algorithm is better, if yes, overwrite the existing algorithm code), and at the same time, you need to add the corresponding code snippets in README.md and README_EN.md (do not have Chinese comments in the English file) In addition, the coding style (such as the naming of variables and functions) should be as consistent as possible with the existing code in the project. |
|
你是指 |
我比较建议留着,因为如果有拷贝题解放本地跑的话,老是报 warning 不是非常美观🤣 |
可以的,留着吧 |
approve了,但是等我先处理一下那个pr-label的ci 再合吧 |
刚才没注意,其实你这个是update 哈哈哈,方便再改不,如果是更新题解的时候一般用update, 新增补充才用add。这样的话,我们就算没有查看详情也可以了解到这个pr做了什么事情。 |
嗯嗯没问题,你已经改了那我就不改了🤣 |
嗯嗯,其实常规就这几种规范,如果有更好的建议也可以一起来完善项目。add-label就是我们新想出来的action。 |
rust 的话可以用 clippy 来保证代码规范 (跟 clang-format 差别不大),我之后有时间研究一下怎么 integrate |
No description provided.