Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update rust solution to lc problem: No.0055 #1609

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Sep 12, 2023

No description provided.

@github-actions
Copy link
Contributor

🤭 感谢你的提交,请检查你的改动是否符合以下项目规范。

1. 格式化

我们项目中各种编程语言代码(包括文档)所采用的格式化工具不同,提交 pr 之前必须确保代码、文档正确格式化。

  • .{md,js,ts,php,sql} 采用 prettier
  • .{c,cpp,java} 采用 clang-format
  • .{py} 采用 black
  • .{go} 采用 gofmt
  • 其它待完善

2. Git 提交信息

我们项目遵循 AngularJS Git Commit Message Conventions 规范,我们希望你的提交信息尽可能与项目保持一致。

  • 新增或修改题解:feat: add/update solution(s) to lc problem(s): No.xxxx
  • 修复错误:fix: xxxx
  • 日常维护:chore: xxx

3. 其它补充

新增题解及代码时,需要创建 Solution.xxx 源代码文件(如果已存在,请确认算法是否更优,是则覆盖已有算法代码),同时,需要在 README.md 以及 README_EN.md 中添加对应的代码片段(英文文件中不要出现中文注释)

另外,编码风格(比如变量、函数的命名),尽量跟项目已有代码保持一致。


🤭 Thank you for your contribution. Please check if your changes comply with the following project specifications.

1. Formatting

We use different formatting tools for various programming languages (including documentation) in our project. You must ensure that the code and documentation are correctly formatted before submitting a pr.

  • .{md,js,ts,php,sql} use prettier
  • .{c,cpp,java} use clang-format
  • .{py} use black
  • .{go} use gofmt
  • Others to be improved

2. Git Commit Message

Our project follows the AngularJS Git Commit Message Conventions. We hope that your submission information is as consistent as possible with the project.

  • Add or modify solutions: feat: add/update solution(s) to lc problem(s): No.xxxx
  • Fix errors: fix: xxxx
  • Routine maintenance: chore: xxx

3. Other notes

When adding solutions and code, you need to create a Solution.xxx source code file (if it already exists, please confirm whether the algorithm is better, if yes, overwrite the existing algorithm code), and at the same time, you need to add the corresponding code snippets in README.md and README_EN.md (do not have Chinese comments in the English file)

In addition, the coding style (such as the naming of variables and functions) should be as consistent as possible with the existing code in the project.

@thinkasany
Copy link
Member

thinkasany commented Sep 12, 2023

  1. pr message 新增或修改题解:feat: add/update solution(s) to lc problem(s): No.xxxx
  2. 这个注解似乎是不是也可以去掉

@xzhseh xzhseh changed the title refactor: change rust solution of No.0055 to conform with the existing solutions feat: add rust solution to lc problem: No.0055 Sep 12, 2023
@xzhseh
Copy link
Contributor Author

xzhseh commented Sep 12, 2023

这个注解似乎是不是也可以去掉

你是指 #[allow(dead_code)]? 这个是防止 rustc 产生 warning 的宏

@thinkasany
Copy link
Member

这个注解似乎是不是也可以去掉

你是指 #[allow(dead_code)]? 这个是防止 rustc 产生 warning 的宏

好的,代码部分很规范,主要我看很多rust题解也省略了这个注解,并且去掉也可以ac。 所以其实是留着更好是吗?
image

@xzhseh
Copy link
Contributor Author

xzhseh commented Sep 12, 2023

我比较建议留着,因为如果有拷贝题解放本地跑的话,老是报 warning 不是非常美观🤣
当然这个宏不会影响正确性的,所以可以放心

@yanglbme
Copy link
Member

可以的,留着吧

@thinkasany
Copy link
Member

thinkasany commented Sep 12, 2023

可以的,留着吧

approve了,但是等我先处理一下那个pr-label的ci 再合吧

@thinkasany
Copy link
Member

我比较建议留着,因为如果有拷贝题解放本地跑的话,老是报 warning 不是非常美观🤣 当然这个宏不会影响正确性的,所以可以放心

刚才没注意,其实你这个是update 哈哈哈,方便再改不,如果是更新题解的时候一般用update, 新增补充才用add。这样的话,我们就算没有查看详情也可以了解到这个pr做了什么事情。

@thinkasany thinkasany changed the title feat: add rust solution to lc problem: No.0055 feat: update rust solution to lc problem: No.0055 Sep 12, 2023
@xzhseh
Copy link
Contributor Author

xzhseh commented Sep 12, 2023

如果是更新题解的时候一般用update, 新增补充才用add

嗯嗯没问题,你已经改了那我就不改了🤣

@thinkasany
Copy link
Member

如果是更新题解的时候一般用update, 新增补充才用add

嗯嗯没问题,你已经改了那我就不改了🤣

嗯嗯,其实常规就这几种规范,如果有更好的建议也可以一起来完善项目。add-label就是我们新想出来的action。

@xzhseh
Copy link
Contributor Author

xzhseh commented Sep 12, 2023

rust 的话可以用 clippy 来保证代码规范 (跟 clang-format 差别不大),我之后有时间研究一下怎么 integrate

@yanglbme yanglbme merged commit 187ac6c into doocs:main Sep 13, 2023
@yanglbme yanglbme added the rs Issues or Pull requests relate to .rs code label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rs Issues or Pull requests relate to .rs code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants