-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rust solution to lc problem: No.2366 #1547
Conversation
🤭 感谢你的提交,请检查你的改动是否符合以下项目规范。 1. 格式化我们项目中各种编程语言代码(包括文档)所采用的格式化工具不同,提交 pr 之前必须确保代码、文档正确格式化。
2. Git 提交信息我们项目遵循 AngularJS Git Commit Message Conventions 规范,我们希望你的提交信息尽可能与项目保持一致。
3. 其它补充新增题解及代码时,需要创建 Solution.xxx 源代码文件(如果已存在,请确认算法是否更优,是则覆盖已有算法代码),同时,需要在 README.md 以及 README_EN.md 中添加对应的代码片段(英文文件中不要出现中文注释) 另外,编码风格(比如变量、函数的命名),尽量跟项目已有代码保持一致。 🤭 Thank you for your contribution. Please check if your changes comply with the following project specifications. 1. FormattingWe use different formatting tools for various programming languages (including documentation) in our project. You must ensure that the code and documentation are correctly formatted before submitting a pr.
2. Git Commit MessageOur project follows the AngularJS Git Commit Message Conventions. We hope that your submission information is as consistent as possible with the project.
3. Other notesWhen adding solutions and code, you need to create a Solution.xxx source code file (if it already exists, please confirm whether the algorithm is better, if yes, overwrite the existing algorithm code), and at the same time, you need to add the corresponding code snippets in README.md and README_EN.md (do not have Chinese comments in the English file) In addition, the coding style (such as the naming of variables and functions) should be as consistent as possible with the existing code in the project. |
其实如果题解和项目中题解思路接近的话,最好用相同的变量命名哈,这样子对的上上面的解题思路。如果用户在使用的时候,切换不同编程语言题解的时候也能能快的理解,api的变化是什么,就少了对参数的理解。 |
是的,我们毕竟是一个社区项目,不是一个个人的小项目,所以我们希望提交的代码,风格上尽可能与项目保持一致,这也有利于读者们理解。 |
这题参数不多,所以刚才直接合进去了,但是我看了一下,似乎其他其他语言的这个mx 换成max会不会更通用一点呢,有需要的话,我可以帮忙改 |
max 不太好,跟函数名一样了,python c++ go 函数名都叫 max,变量名最好别跟函数名一样 |
好的 理解了 |
没问题~ |
No description provided.