-
Notifications
You must be signed in to change notification settings - Fork 1
Add Jekyll integration + Bootstrap 4 #3
Conversation
Add Jeckyll integration Changed: - Remove duplicate content (header, footer, navbar, ...) by using Jeckyll - Use external bootstrap instead of /components/bootstrap - Use external jquery instead of /components/jquery - Use bootstrap 4 instead of 3
Add Jeckyll integration
Fix <a en <image urls
Fix typo in {{ site.baseUrl }}, it should be {{ site.baseurl }}
Add ".active" to navigation for current page
|
If there are any questions, I'd be happy to answer them. Note: you can view the result over here: https://jeroendesloovere.github.io/dockerwest.github.io |
Update Google Analytics - Use site.google_analytics variable - Fix site in tracking code
|
Thanks, but in the drafts branch we use sculpin and just publish the generated html to master. Its still worth looking into jeckyll if that would reduce the steps needed to add something to the site. |
|
Does it provide an rss feed? I see the atom.xml is not changed by the jekyll change |
|
Hi @BlackIkeEagle, Thanks for taking the time to answer my PR.
Questions from my part if you want me to finish the PR:
Otherwise, it was a nice project for learning Jekyll. |
|
We might want to do blogs in the future, but currently there is nothing there :) I'll discuss it if we possibly want to switch to jekyll from sculpin or not. I'll let you know |
|
If you have the time, you can finish this. If the feeds are also available it would be great. |
Remove obsolete .panel-body elements We don't need them anymore in bootstrap 4. The same functionality has been replaced by .card-body
|
Done |
Pull request description
Fixes #1
Changes
Result
You can view the result over here: https://jeroendesloovere.github.io/dockerwest.github.io

The layout is practically identical to the one you guys now have.
Note
I have not touched any of the code you guys wrote.
Just converted it into a Jekyll site.