Skip to content
This repository was archived by the owner on May 11, 2025. It is now read-only.

Conversation

@jeroendesloovere
Copy link
Contributor

@jeroendesloovere jeroendesloovere commented May 16, 2018

Pull request description

Fixes #1

Jekyll is the number one supported static site generator for Github Pages.

Changes

  • Remove lots of duplicate content (header, footer, navbar, ...) by using Jekyll
  • Use external bootstrap instead of /components/bootstrap
  • Use external jquery instead of /components/jquery
  • Use bootstrap 4 instead of 3

Result

You can view the result over here: https://jeroendesloovere.github.io/dockerwest.github.io
The layout is practically identical to the one you guys now have.
schermafbeelding 2018-05-16 om 16 01 00

Note

I have not touched any of the code you guys wrote.
Just converted it into a Jekyll site.

@jeroendesloovere
Copy link
Contributor Author

jeroendesloovere commented May 16, 2018

If there are any questions, I'd be happy to answer them.

Note: you can view the result over here: https://jeroendesloovere.github.io/dockerwest.github.io

@jeroendesloovere jeroendesloovere changed the title Add Jeckyll integration Add Jekyll integration May 16, 2018
Update Google Analytics

- Use site.google_analytics variable
- Fix site in tracking code
@BlackIkeEagle
Copy link
Member

Thanks, but in the drafts branch we use sculpin and just publish the generated html to master.

Its still worth looking into jeckyll if that would reduce the steps needed to add something to the site.

@BlackIkeEagle
Copy link
Member

Does it provide an rss feed? I see the atom.xml is not changed by the jekyll change

@jeroendesloovere
Copy link
Contributor Author

jeroendesloovere commented May 22, 2018

Hi @BlackIkeEagle,

Thanks for taking the time to answer my PR.
It was my first experience with Jekyll and thought it was fun to convert your project to it.

  1. I did not know you were already using a static site generator and did not notice the drafts branch. To me, it seems faster to just having the "source" files in "master" branch - and let Github compile everything (local compiling is also possible very easily) - seems like a faster way of working... Don't you agree?
  2. Currently I did not touch the RSS feed, but indeed, it would be nice if that should be created automatically. That is possible using one of these:

Questions from my part if you want me to finish the PR:

  • I assume the blog directory can be removed entirely?

Otherwise, it was a nice project for learning Jekyll.
Which is actually pretty easy to use.

@BlackIkeEagle
Copy link
Member

We might want to do blogs in the future, but currently there is nothing there :)

I'll discuss it if we possibly want to switch to jekyll from sculpin or not. I'll let you know

@jeroendesloovere jeroendesloovere changed the title Add Jekyll integration Add Jekyll integration + Bootstrap 4 May 22, 2018
@BlackIkeEagle
Copy link
Member

If you have the time, you can finish this. If the feeds are also available it would be great.

Remove obsolete .panel-body elements

We don't need them anymore in bootstrap 4.
The same functionality has been replaced by .card-body
@jeroendesloovere
Copy link
Contributor Author

Done

@BlackIkeEagle BlackIkeEagle self-requested a review May 24, 2018 10:21
@BlackIkeEagle BlackIkeEagle merged commit 6da3fc3 into dockerwest:master May 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

static site generator?

2 participants