Enforce that GitCommit must be a *full* commit hash
#105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought this was already the behavior, but I guess it was relaxed because previous iterations of this validation had to apply to the older format where we'd been less meticulous about enforcing this. Since those are all gone now, we can safely update the validation to enforce that commit hashes *must* be fully qualified.
yosifkit
approved these changes
Aug 13, 2024
Member
Author
|
Some validation against https://github.com/docker-library/official-images: $ git log -1 --oneline --no-decorate
bb7a6a131 Merge pull request #17351 from yaooqinn/patch-1
$ grep --no-filename 'GitCommit:' -- library/* | cut -d: -f2 | xargs -n1 | sort -u | grep -vE '^.{40}$'
$ bashbrew --library library cat --all > /dev/null
$ |
whalelines
approved these changes
Aug 13, 2024
whalelines
left a comment
whalelines
left a comment
There was a problem hiding this comment.
Doubly good to also eliminate the possibility of supplying a one-character hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this was already the behavior, but I guess it was relaxed because previous iterations of this validation had to apply to the older format where we'd been less meticulous about enforcing this. Since those are all gone now, we can safely update the validation to enforce that commit hashes must be fully qualified.