Skip to content

Review super calls for customElementsV1+ branch #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Review super calls for customElementsV1+ branch #6

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c7c31f3
Move A-Frame to customElementsV1 API
dmarcos Oct 12, 2022
effe9ad
Introduce Mutation Observer
dmarcos Oct 12, 2022
b523641
Add polyfill
dmarcos Oct 13, 2022
93b48e2
Call super instead of prototype
dmarcos Oct 14, 2022
20dee52
Replace custom-element polyfill
dmarcos Oct 19, 2022
e95337c
Replace .call(this) invocations
dmarcos Oct 19, 2022
84fb55a
fix super calls
vincentfretin Oct 16, 2022
550aa3d
put back doConnectedCallback
vincentfretin Oct 21, 2022
5da88aa
don't use this.doConnectedCallback() for a-node and a-entity
vincentfretin Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add polyfill
  • Loading branch information
@dmarcos
dmarcos committed Oct 13, 2022
commit b52364138e19fc533bb66f1d6a5f1ed270a6761f
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"custom-event-polyfill": "^1.0.6",
"debug": "ngokevin/debug#noTimestamp",
"deep-assign": "^2.0.0",
"document-register-element": "^1.13.2",
"@webreflection/custom-elements": "^1.1.0",
"load-bmfont": "^1.2.3",
"object-assign": "^4.0.1",
"present": "0.0.6",
Expand Down
6 changes: 6 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
// Polyfill `Promise`.
window.Promise = window.Promise || require('promise-polyfill');

// Custom Elements v1 polyfill
if (!window.customElements) {
const customElementsPolyfill = require('@webreflection/custom-elements');
customElementsPolyfill(window || global);
}

// WebVR polyfill
// Check before the polyfill runs.
window.hasNativeWebVRImplementation = !!window.navigator.getVRDisplays ||
Expand Down