Test on Django 4.2 #1264
Merged
Test on Django 4.2 #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
adamchainz
commented
Apr 14, 2023
Comment on lines
+28
to
+29
| if django.VERSION < (4, 0): | ||
| USE_L10N = True |
Contributor
Author
There was a problem hiding this comment.
This change avoids a warning on Django 4.0+:
/.../site-packages/django/conf/__init__.py:267: RemovedInDjango50Warning: The USE_L10N setting is deprecated. Starting with Django 5.0, localized formatting of data will always be enabled. For example Django will display numbers and dates using the format of the current locale.
warnings.warn(USE_L10N_DEPRECATED_MSG, RemovedInDjango50Warning)
Codecov Report
@@ Coverage Diff @@
## master #1264 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 31 31
Lines 1821 1821
=======================================
Hits 1766 1766
Misses 55 55 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Oct 27, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Test with the new Django! 🎉
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS