DEV: Adding specs and refactors #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-brennan
changed the title
Return an array of hashes instead of an array of arrays, this simplifies the component too. Also, remove unnecessary htmlSafe in the component.
martin-brennan
force-pushed
the
dev/adding-specs-and-refactors
branch
from
e1c745b to
31cef0d
Compare
Also make it so we limit the amount of words returned on the server, no point returning 100 to the client and slicing.
Merged
martin-brennan
force-pushed
the
dev/adding-specs-and-refactors
branch
from
eb98d91 to
87303b5
Compare
Made a simpler best_book_fit method that still works the way we want it to
martin-brennan
force-pushed
the
dev/adding-specs-and-refactors
branch
from
b77d53c to
6dcdd52
Compare
martin-brennan
force-pushed
the
dev/adding-specs-and-refactors
branch
from
6dcdd52 to
dd10012
Compare
jjaffeux
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add specs for the following reports:
Did some minor UI and ruby refactors for related components.
Also made a minor change to the Activity calendar, to show a title based on the number of posts or if the user was active on hover.
Still missing specs for:
And the newly added reports that don't yet have UI components.