Skip to content

Conversation

@vincefn
Copy link
Collaborator

@vincefn vincefn commented Nov 28, 2021

This PR:

  • gives access to the weight (g/mol) for ScatteringPowerAtom and Crystal
  • avoids crashes when using Crystal::XMLInput(...) when the crystal is not empty, and re-uses the scattering pwoer when possible
  • Small correction to GetFormula for Crystal and Molecule

Associated pyobjcryst PR to come.

…jcryst

* 'master' of github.com:vincefn/objcryst:
  Add access to the weight (g/mol) for ScatteringPowerAtom and Crystal
* upstream-objcryst:
  Add access to the weight (g/mol) for ScatteringPowerAtom and Crystal
…jcryst

* 'master' of github.com:vincefn/objcryst:
  Add access to the weight (g/mol) for ScatteringPowerAtom and Crystal
* upstream-objcryst:
  Add access to the weight (g/mol) for ScatteringPowerAtom and Crystal
…jcryst

* 'master' of github.com:vincefn/objcryst:
  Correct precision for Crystal::GetFormula()
* upstream-objcryst:
  Correct precision for Crystal::GetFormula()
…jcryst

* 'master' of github.com:vincefn/objcryst:
  Add relative_length_tolerance and absolute_angle_tolerance_degree to SpaceGroupExplorer::Run() and RunAll()
* upstream-objcryst:
  Add relative_length_tolerance and absolute_angle_tolerance_degree to SpaceGroupExplorer::Run() and RunAll()
…n mDeleteSubObjInDestructor is False. This is useful when re-loading Crystal configurations using their xml descriptions repeatedly, notably in python.
* objcryst/master:
  Crystal::XMLInput(): add a hook to re-use atomic scattering power when mDeleteSubObjInDestructor is False. This is useful when re-loading Crystal configurations using their xml descriptions repeatedly, notably in python.
* upstream-objcryst:
  Crystal::XMLInput(): add a hook to re-use atomic scattering power when mDeleteSubObjInDestructor is False. This is useful when re-loading Crystal configurations using their xml descriptions repeatedly, notably in python.
* objcryst/master:
  Better GetFormula for Crystal and Molecule
* upstream-objcryst:
  Better GetFormula for Crystal and Molecule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants