Skip to content

Conversation

@stevenhua0320
Copy link
Contributor

No description provided.

@stevenhua0320
Copy link
Contributor Author

@sbillinge Ready to review, have made the change to CI

@sbillinge
Copy link
Contributor

@stevenhua0320 please could you check the workflows? I think it should be running pre-commit in ci now we recognize it as open source. Maybe it is better to use the scikit-package workflow files to make sure we have everything right?

@stevenhua0320
Copy link
Contributor Author

@sbillinge The workflow for diffpy.srxplanargui is close-sourced. I think previously we decide this subpackage is close source so we should use close sourced workflow like pdfgetx? Or now we change it to open source? I'm not quite sure

@sbillinge
Copy link
Contributor

We are not changing any of the licenses. So this should stay closed source for now

@sbillinge sbillinge merged commit 2f2bd85 into diffpy:main Oct 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants