chore:delete unused module, change lambda def to def #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmx27
reviewed
Sep 26, 2025
| ] | ||
| editor.refresh() | ||
| except: | ||
| except ImportError: |
Collaborator
There was a problem hiding this comment.
Why import error? I don't see any imports here...
Contributor
Author
There was a problem hiding this comment.
Have changed to AttributeError, see the update
stevenhua0320
changed the title
Contributor
Author
|
@zmx27 Ready for another review |
zmx27
reviewed
Sep 26, 2025
| ] | ||
| editor.refresh() | ||
| except: | ||
| except AttributeError: |
Collaborator
There was a problem hiding this comment.
Do you think that this could also potentially result in a IndexError when the code can't find any TableEditorsBE objects? Could you look into this?
Contributor
Author
There was a problem hiding this comment.
Yes, you are right IndexError might also occur in the process. Have changed that in updated commit
Collaborator
There was a problem hiding this comment.
I think this PR looks good now
Contributor
Author
|
@sbillinge Ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zmx27 ready for review
-Remove unused modules
-change lambda def to standard def
-avoid bare except