Skip to content

Conversation

@Tieqiong
Copy link
Contributor

This PR is for replacing the danse links (not including the links related to documentations). Those will be included in a later PR. Together will closes the two previous PRs (#202 and #203 )

@sbillinge As for the documentation links, it seems like some of them were not deployed (even though we have run the deploy workflows). This can be checked under the Action tab Management field. The good ones (like structure) has the Deployment link and GitHub-pages bot ran. But for packages like pdfgui, pdffit2, cookiecutter they don't have the api/documentation pages release.

I think there are configurations needed to be changed in the repo settings-Code and automation-Pages

@codecov
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (dd9f989) to head (a52ab22).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          23       23           
  Lines        1126     1126           
=======================================
  Hits         1071     1071           
  Misses         55       55           
Files with missing lines Coverage Δ
tests/test_aboutdialog.py 96.96% <100.00%> (ø)

@sbillinge
Copy link
Contributor

This PR is for replacing the danse links (not including the links related to documentations). Those will be included in a later PR. Together will closes the two previous PRs (#202 and #203 )

@sbillinge As for the documentation links, it seems like some of them were not deployed (even though we have run the deploy workflows). This can be checked under the Action tab Management field. The good ones (like structure) has the Deployment link and GitHub-pages bot ran. But for packages like pdfgui, pdffit2, cookiecutter they don't have the api/documentation pages release.

I think there are configurations needed to be changed in the repo settings-Code and automation-Pages

Thanks for this Tieqiong. Please can you make an issue to re-cookiecut gui and fit2? I will merge this for now

@sbillinge sbillinge merged commit 0e230e0 into diffpy:main Dec 26, 2024
5 checks passed
@Tieqiong
Copy link
Contributor Author

Tieqiong commented Dec 26, 2024

@sbillinge Thanks. Just to make sure, we want to re-cookiecut gui and fit2 again? (as I thought we are almost there for releasing them). So we added more things to the cookiecutter?

@sbillinge
Copy link
Contributor

@sbillinge Thanks. Just to make sure, we want to re-cookiecut gui and fit2 again? (as I thought we are almost there for releasing them). So we added more things to the cookiecutter?

I thought you mentioned that the GitHub workflows need to be updated so the docs will build correctly.

@Tieqiong
Copy link
Contributor Author

@sbillinge ah I think it's not about the workflows, as they are all using the same one. It's the GitHub repository settings that make sure GitHub-pages bot can generate and deploy pages on Github's side. I believe cookiecutter is the one that bob recutted lately, and it also doesn't have docs deployed, even if it has a deploy docs workflow.

I think it's just the GitHub-page bot is not setup correctly in the repository setting. I guess it's related to some configurations at Settings-Code and automation-Pages

@sbillinge
Copy link
Contributor

@sbillinge ah I think it's not about the workflows, as they are all using the same one. It's the GitHub repository settings that make sure GitHub-pages bot can generate and deploy pages on Github's side. I believe cookiecutter is the one that bob recutted lately, and it also doesn't have docs deployed, even if it has a deploy docs workflow.

I think it's just the GitHub-page bot is not setup correctly in the repository setting. I guess it's related to some configurations at Settings-Code and automation-Pages

Ah, ok, I can work on that.

@Tieqiong Tieqiong deleted the danselink branch January 14, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants