-
Notifications
You must be signed in to change notification settings - Fork 38
replace danse links (without documentations) #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 23 23
Lines 1126 1126
=======================================
Hits 1071 1071
Misses 55 55
|
Thanks for this Tieqiong. Please can you make an issue to re-cookiecut gui and fit2? I will merge this for now |
|
@sbillinge Thanks. Just to make sure, we want to re-cookiecut gui and fit2 again? (as I thought we are almost there for releasing them). So we added more things to the cookiecutter? |
I thought you mentioned that the GitHub workflows need to be updated so the docs will build correctly. |
|
@sbillinge ah I think it's not about the workflows, as they are all using the same one. It's the GitHub repository settings that make sure GitHub-pages bot can generate and deploy pages on Github's side. I believe cookiecutter is the one that bob recutted lately, and it also doesn't have docs deployed, even if it has a deploy docs workflow. I think it's just the GitHub-page bot is not setup correctly in the repository setting. I guess it's related to some configurations at |
Ah, ok, I can work on that. |
This PR is for replacing the danse links (not including the links related to documentations). Those will be included in a later PR. Together will closes the two previous PRs (#202 and #203 )
@sbillinge As for the documentation links, it seems like some of them were not deployed (even though we have run the deploy workflows). This can be checked under the Action tab Management field. The good ones (like structure) has the
Deploymentlink and GitHub-pages bot ran. But for packages like pdfgui, pdffit2, cookiecutter they don't have the api/documentation pages release.I think there are configurations needed to be changed in the repo settings-Code and automation-Pages