Skip to content

Conversation

@Sparks29032
Copy link
Collaborator

New issue raised involving testing MorphISpheroid see (#79).

Also, on ni_qmax25_psize30.cgr, G(r) is non-zero until 35, not 30. Should psize be changed to 35?

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #80 (f8a8b82) into main (ad4df08) will increase coverage by 0.90%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   74.11%   75.01%   +0.90%     
==========================================
  Files          36       36              
  Lines        1406     1437      +31     
==========================================
+ Hits         1042     1078      +36     
+ Misses        364      359       -5     
Impacted Files Coverage Δ
diffpy/pdfmorph/morphs/morphishape.py 81.25% <60.00%> (+15.73%) ⬆️
diffpy/pdfmorph/tests/test_morphshape.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sbillinge
Copy link
Contributor

New issue raised involving testing MorphISpheroid see (#79).

Also, on ni_qmax25_psize30.cgr, G(r) is non-zero until 35, not 30. Should psize be changed to 35?

I think that is a yes on 30 vs 35. Good catch.

@sbillinge sbillinge merged commit 6fdf12b into diffpy:main Jun 24, 2023
@sbillinge
Copy link
Contributor

great @Sparks29032

@Sparks29032 Sparks29032 deleted the testdata_metadata branch May 30, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants