Skip to content

Conversation

@ycexiao
Copy link
Collaborator

@ycexiao ycexiao commented Feb 8, 2025

close #161

@ycexiao ycexiao marked this pull request as ready for review February 8, 2025 16:10
@ycexiao
Copy link
Collaborator Author

ycexiao commented Feb 8, 2025

@sbillinge It's ready for review, thank you.

@bobleesj
Copy link
Contributor

bobleesj commented Feb 8, 2025

This looks like a better solution - assuming local test and GH pass.

@bobleesj
Copy link
Contributor

bobleesj commented Feb 8, 2025

@ycexiao also the PR title can be a bit clarified.

The only use information in the title is "new" - we might want to add information that this PR directly imports loaddata and deserializae methods from diffpy.util 3.6.0 (also news should be clarified that it's an API update to be compatiable with diffpy.utils 3.6.0)

@ycexiao ycexiao changed the title fix: use new parsers api fix: import loadData and deserialize_data directly to adopt new API from diffpy.utils(3.6.0) Feb 8, 2025
@ycexiao
Copy link
Collaborator Author

ycexiao commented Feb 8, 2025

@ycexiao also the PR title can be a bit clarified.

The only use information in the title is "new" - we might want to add information that this PR directly imports loaddata and deserializae methods from diffpy.util 3.6.0 (also news should be clarified that it's an API update to be compatiable with diffpy.utils 3.6.0)

Thank you. Details have been added to issue title and news

@sbillinge
Copy link
Contributor

Thanks @ycexiao , good changes! I like it.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ycexiao . Code fixes look good (I didn't check tests pass yet), but please see the comment about the news.


**Changed:**

* import `loadData` and `deserialize_data` directly to integrate with `diffpy.utils(3.6.0)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move to fixed. this is a fix (bug) not a change (change in behavior of the program that users need to know about)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Updates have been pushed.

@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (641b5e7) to head (bb67d96).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files          18       18           
  Lines         795      795           
=======================================
  Hits          770      770           
  Misses         25       25           

@ycexiao
Copy link
Collaborator Author

ycexiao commented Feb 9, 2025

@sbillinge It's ready for another review.

@sbillinge sbillinge merged commit fa1dd17 into diffpy:main Feb 9, 2025
5 checks passed
@bobleesj
Copy link
Contributor

bobleesj commented Feb 9, 2025

Amazing! @ycexiao

@ycexiao ycexiao deleted the parser-api branch February 9, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: compatibility with new diffpy.utils.parsers API

3 participants