update pdfgui webpage into py3 version. #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ok, great.
…On Mon, Apr 24, 2023 at 4:09 PM longyang ***@***.***> wrote:
@sbillinge <https://github.com/sbillinge> , please review all the
writing. But do not merge yet.
I will update the PDFgui user manual, then I will ping you again to merge.
------------------------------
You can view, comment on, or merge this pull request online at:
#51
Commit Summary
- 82a4ecd
<82a4ecd>
ENH: update pdfgui webpage into py3 version.
File Changes
(2 files <https://github.com/diffpy/diffpy.github.io/pull/51/files>)
- *M* products/PDFgui_LICENSE.txt
<https://github.com/diffpy/diffpy.github.io/pull/51/files#diff-b67be35bd97276d988173bd40b2d818095a929ebc742209c8927af7e97b7e46b>
(39)
- *M* products/pdfgui.rst
<https://github.com/diffpy/diffpy.github.io/pull/51/files#diff-a75aa99821c52dc80ce5cdb1c3452fac4227f325125f8614ed6de71d12ffb4ff>
(70)
Patch Links:
- https://github.com/diffpy/diffpy.github.io/pull/51.patch
- https://github.com/diffpy/diffpy.github.io/pull/51.diff
—
Reply to this email directly, view it on GitHub
<#51>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUI65Q5J3NO2NJQG57DXC2JSFANCNFSM6AAAAAAXJXES44>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Simon Billinge
Professor, Columbia University
|
dragonyanglong
changed the title
Contributor
Author
|
@sbillinge this PR is ready to be merged now. Please review and merge. |
Contributor
Author
|
@sbillinge please review and merge. |
Contributor
|
super! Done!
…On Fri, May 5, 2023 at 5:54 PM longyang ***@***.***> wrote:
@sbillinge <https://github.com/sbillinge> please review and merge.
—
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUJDY5MAMSZAQ2OSTRTXEUWFVANCNFSM6AAAAAAXJXES44>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Simon Billinge
Professor, Columbia University
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbillinge , please review all the writing. But do not merge yet.
I will update the PDFgui user manual, then I will ping you again to merge.