Skip to content

Conversation

@connorjbracy
Copy link
Contributor

@sbillinge, this PR should be ready for merge and contains the compiled source files (pushed in PR #49). That is, this PR contains the files that will actually publish the pdfgetx v2.2.1 release onto diffpy.org

@connorjbracy
Copy link
Contributor Author

@sbillinge, I noticed the considerable number of changes logged once the PR was opened. Upon examination, it appears that there are many changes resulting from a newer (+3 years) version of Sphinx being used to generate these files compared with the previous set of files in master, resulting in many tiny changes throughout many files. If you'd like me to investigate this further, let me know.

@sbillinge
Copy link
Contributor

sbillinge commented Mar 22, 2022 via email

@connorjbracy
Copy link
Contributor Author

Let's just go with it... We can then look at the docs and see what they look like.

On Tue, Mar 22, 2022, 2:27 PM Connor J. Bracy @.> wrote: @sbillinge https://github.com/sbillinge, I noticed the considerable number of changes logged once the PR was opened. Upon examination, it appears that there are many changes resulting from a newer (+3 years) version of Sphinx being used to generate these files compared with the previous set of files in master, resulting in many tiny changes throughout many files. If you'd like me to investigate this further, let me know. — Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUMOHAXT675ZLIQZGJLVBIGIFANCNFSM5RLVZIZA . You are receiving this because you were mentioned.Message ID: @.>

@sbillinge, it seems I don't have write access to this repo so you'll have to merge the PR.

@sbillinge sbillinge merged commit f522ab6 into diffpy:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants