You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note This PR should contain the changes to the static files of diffpy.org necessary to update the site to what it should be for hosting pdfgetx v2.1.1, but it is not reflecting those changes within my fork's GitHub pages site. Do with this information what you will, I'll look into it more when I'm done travelling...
Duplication of Slack message
I'm thinking it might be some weirdness to do with the fork being of a GitHub pages repo, but I'm not really sure. My flight is about to start boarding but I figured I'd give you a sitrep so you know where things stand. I'll also open a PR for the changes that should update the website in case you have a way to preview them or want to test if merging them would update the site (with accepting that undoing the commit may be necessary, if needed, but also the non-update I'm observing seems to leave the website entirely as it currently is so maybe a revert won't be needed even if the changes are ineffective).
Note This PR should contain the changes to the static files of diffpy.org necessary to update the site to what it should be for hosting pdfgetx v2.1.1, but it is not reflecting those changes within my fork's GitHub pages site. Do with this information what you will, I'll look into it more when I'm done travelling...
Duplication of Slack message I'm thinking it might be some weirdness to do with the fork being of a GitHub pages repo, but I'm not really sure. My flight is about to start boarding but I figured I'd give you a sitrep so you know where things stand. I'll also open a PR for the changes that should update the website in case you have a way to preview them or want to test if merging them would update the site (with accepting that undoing the commit may be necessary, if needed, but also the non-update I'm observing seems to leave the website entirely as it currently is so maybe a revert won't be needed even if the changes are ineffective).
@sbillinge, the diff is even less human-readable in raw form than I hoped. It's probably best to hold off on touching this until I can work again :(
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge, BEFORE MERGING, READ BELOW
Note This PR should contain the changes to the static files of diffpy.org necessary to update the site to what it should be for hosting
pdfgetx v2.1.1, but it is not reflecting those changes within my fork's GitHub pages site. Do with this information what you will, I'll look into it more when I'm done travelling...Duplication of Slack message
I'm thinking it might be some weirdness to do with the fork being of a GitHub pages repo, but I'm not really sure. My flight is about to start boarding but I figured I'd give you a sitrep so you know where things stand. I'll also open a PR for the changes that should update the website in case you have a way to preview them or want to test if merging them would update the site (with accepting that undoing the commit may be necessary, if needed, but also the non-update I'm observing seems to leave the website entirely as it currently is so maybe a revert won't be needed even if the changes are ineffective).