Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

closes #84

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review. This gets rid of subprocess, but the tradeoff is now we use monkeypatch. In a way this is kind of a workaround but might be okay for this given case. Let me know what your think.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.63%. Comparing base (f6ce689) to head (cd1eb20).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   92.78%   92.63%   -0.16%     
==========================================
  Files           3        3              
  Lines         194      190       -4     
==========================================
- Hits          180      176       -4     
  Misses         14       14              
Files with missing lines Coverage Δ
tests/conftest.py 88.88% <ø> (-1.23%) ⬇️
tests/test_packsmanager.py 95.23% <100.00%> (+0.28%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good but we use in teh group pytest.mocker and not monkeypatch, please could you replace with that?

@cadenmyers13
Copy link
Contributor Author

@sbillinge done. ready for review

@sbillinge sbillinge merged commit 296c941 into diffpy:main Nov 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: fix test_print_packs_and_examples to mock imports

2 participants