-
Notifications
You must be signed in to change notification settings - Fork 5
bug: Ship examples in MANIFEST.in
#85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sbillinge ready for review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 3 3
Lines 194 194
=======================================
Hits 180 180
Misses 14 14 🚀 New features to boost your workflow:
|
|
Wait, we didn't discover this in the RC release? I thought you told me everything was working in the cli? |
sbillinge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comment
MANIFEST.in
Outdated
| include AUTHORS.rst LICENSE*.rst README.rst | ||
|
|
||
| # include examples inside the package | ||
| recursive-include src/diffpy/cmi/docs/examples * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check this. This is not the right path to the example files, right. We should check where we want them placed in the distribution so everything works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
@sbillinge ready for review. This works as i tested it in https://test.pypi.org/. I made a test release there, installed from there, and |
|
,@cadenmyers13 I can do this next RC release this afternoon |
|
@sbillinge great, thanks |
The recent pypi release doesn't ship the examples. added this to ship them.