Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

The recent pypi release doesn't ship the examples. added this to ship them.

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.78%. Comparing base (a536d4e) to head (52ccaa9).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files           3        3           
  Lines         194      194           
=======================================
  Hits          180      180           
  Misses         14       14           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

Wait, we didn't discover this in the RC release? I thought you told me everything was working in the cli?

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment

MANIFEST.in Outdated
include AUTHORS.rst LICENSE*.rst README.rst

# include examples inside the package
recursive-include src/diffpy/cmi/docs/examples *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check this. This is not the right path to the example files, right. We should check where we want them placed in the distribution so everything works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review. This works as i tested it in https://test.pypi.org/. I made a test release there, installed from there, and cmi info worked. Sorry about all of this...

@sbillinge sbillinge merged commit 710076e into diffpy:main Nov 13, 2025
7 checks passed
@sbillinge
Copy link
Contributor

,@cadenmyers13 I can do this next RC release this afternoon

@cadenmyers13 cadenmyers13 deleted the ship-examples branch November 13, 2025 16:30
@cadenmyers13
Copy link
Contributor Author

@sbillinge great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants