Update ktfmt default version and add dropbox-style option #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franvis
force-pushed
the
add_dropbox_style_option_to_ktfmt
branch
2 times, most recently
from
75f0fb4 to
6598bf0
Compare
…spaces block and continuation indenting
franvis
force-pushed
the
add_dropbox_style_option_to_ktfmt
branch
from
6598bf0 to
f5e158d
Compare
nedtwigg
requested changes
Jul 10, 2020
There was a problem hiding this comment.
Thanks very much for this PR, we'll definitely get it merged after a bit of work. All my feedback is inline, except for this request:
- in
plugin-maven/CHANGES.md, please add a changelog entry that says:- Bump default
ktfmtfrom0.13to0.15(#641).
- Bump default
plugin-gradle/src/test/java/com/diffplug/gradle/spotless/KotlinGradleExtensionTest.java
Outdated
Show resolved
Hide resolved
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/KotlinExtension.java
Outdated
Show resolved
Hide resolved
…tfmt version update in the maven plugin
|
This LGTM. Anything else you'd like before I merge and release? |
|
I also think it looks good! 🚀 |
|
Published in |
facebook-github-bot
pushed a commit
to facebook/ktfmt
that referenced
this pull request
Jul 15, 2020
…ptions (#53) Summary: Add a public api to represent dropbox style formatting options in order to avoid the duplication of formatting logic from consumers of ktfmt such as in: diffplug/spotless#642 Pull Request resolved: #53 Reviewed By: hick209 Differential Revision: D22530063 Pulled By: cgrushko fbshipit-source-id: 67a03e761ca9f36aed0de7c422f03db75d0fd605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ktfmt default version and add dropbox-style option to allow 4 spaces block and continuation indenting.
Solves: #641