Feature/pass filename to prettier #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the name of the currently formatted file, prettier is now able to use different parsers on a filecollection containing mixing resources such as js/html/css and the like by peeking at the actual filename.
nedtwigg
requested changes
Jun 22, 2020
lib/src/main/java/com/diffplug/spotless/npm/PrettierFormatterStep.java
Outdated
Show resolved
Hide resolved
and create a separate instance dedicated to support filenames
(and since we already handle the "empty" filename correctly, there is nothing to done)
simschla
commented
Jun 23, 2020
| @@ -38,7 +38,8 @@ void install() { | |||
| } | |||
|
|
|||
| Process start() { | |||
| return npm("start"); | |||
| // adding --scripts-prepend-node-path=true due to https://github.com/diffplug/spotless/issues/619#issuecomment-648018679 | |||
| return npm("start", "--scripts-prepend-node-path=true"); | |||
There was a problem hiding this comment.
As a reaction to the discussion in #619 - make sure we always use the node binary associated with the npm binary we use.
…epends on: - the content that gets passed in - the filename - the content which is expected And that's it - there's no filename in and different filename out. So there should only be 3 arguments, not 4. Also brought format to be consistent with StepHarness.
…o need to bring in that complexity.
|
I made some tweaks to |
nedtwigg
approved these changes
Jun 23, 2020
Awesome, thank you for that - the changes make sense and reducing the degrees of freedom in |
|
Published in maven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my take for fixing #448 - pass the filename into prettier to let it choose the correct formatter on its own.