Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding skip to apply mojo #367

Merged
merged 3 commits into from
Mar 7, 2019
Merged

adding skip to apply mojo #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ad251d
adding skip to apply mojo
rmannibucau Mar 7, 2019
cb08c1b
adding entry in CHANGES for the maven plugin for the addition of the …
rmannibucau Mar 7, 2019
304cc1b
Merge branch 'master' into adding-skip-to-apply-mojo
rmannibucau Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugin-maven/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
* Provided eclipse-wtp formatters as part of custom source format element. ([#325](https://github.com/diffplug/spotless/pull/325)). This change obsoletes the CSS and XML source elements.
* Updated default google-java-format from 1.5 to 1.7 ([#335](https://github.com/diffplug/spotless/issues/335)).
* `<importOrder><file>somefile</file></importOrder>` is now lazy ([#218](https://github.com/diffplug/spotless/issues/218)).
* Add a skip parameter to apply mojo to enable to bypass it if desired. ([#367](https://github.com/diffplug/spotless/pull/367)).

### Version 1.17.0 - December 13th 2018 ([javadoc](https://diffplug.github.io/spotless/javadoc/spotless-maven-plugin/1.17.0/), [jcenter](https://bintray.com/diffplug/opensource/spotless-maven-plugin/1.17.0))

Expand Down
8 changes: 8 additions & 0 deletions plugin-maven/src/main/java/com/diffplug/spotless/maven/SpotlessApplyMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import org.apache.maven.plugin.MojoExecutionException;
import org.apache.maven.plugins.annotations.Mojo;
import org.apache.maven.plugins.annotations.Parameter;

import com.diffplug.spotless.Formatter;

Expand All @@ -29,9 +30,16 @@
*/
@Mojo(name = "apply", threadSafe = true)
public class SpotlessApplyMojo extends AbstractSpotlessMojo {
@Parameter(property = "spotless.apply.skip", defaultValue = "false")
private boolean skip;

@Override
protected void process(List<File> files, Formatter formatter) throws MojoExecutionException {
if (skip) {
getLog().info("Spotless apply skipped");
return;
}

for (File file : files) {
try {
formatter.applyTo(file);
Expand Down