-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade diktat to 1.2.0 #1246
Upgrade diktat to 1.2.0 #1246
Conversation
Hi, We (diktat) released the new version |
Probably there can be some problems with backward compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the code now requires 1.2.0
or greater, that's fine, but:
- it needs to be marked in the changelogs
DiktatStep.create
needs to parse the version number, and proactively throw an error if less than 1.2.0 (BadSemver
should make this pretty easy.)
lib/src/diktat/java/com/diffplug/spotless/glue/diktat/DiktatFormatterFunc.java
Show resolved
Hide resolved
(Also you need to run |
c0b44c8
to
f6de4bb
Compare
@nedtwigg, new version of As I can see, there is |
Correct, Spotless classloaders are isolated. BTW, this PR bumps diktat to 1.2.1, which seems to not exist. I'm going to downgrade this to 1.2.0 https://search.maven.org/artifact/org.cqfn.diktat/diktat-rules |
Released in |
Bump default
diktat
version to latest1.1.0
->1.2.0
It closes saveourtool/diktat#1399