Skip to content

Conversation

@dfed
Copy link
Owner

@dfed dfed commented Jan 10, 2024

When we merge, I'll need to add the linux check and macCatalyst checks as required on all PRs.

We'll add visionOS checks to CI once Xcode 15.2 is generally available, but for now I've run tests locally on a beta install of Xcode 15.2.

@codecov
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a7f8ad) 100.00% compared to head (70a8c4d) 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          921       921           
=========================================
  Hits           921       921           

Comment on lines -5 to -7
[![Version](https://img.shields.io/cocoapods/v/AsyncQueue.svg)](https://cocoapods.org/pods/AsyncQueue)
[![License](https://img.shields.io/cocoapods/l/AsyncQueue.svg)](https://cocoapods.org/pods/AsyncQueue)
[![Platform](https://img.shields.io/cocoapods/p/AsyncQueue.svg)](https://cocoapods.org/pods/AsyncQueue)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing these cocoapods badges in favor of swiftpackageindex badges

@@ -1,10 +1,9 @@
# swift-async-queue
[![CI Status](https://img.shields.io/github/actions/workflow/status/dfed/swift-async-queue/ci.yml?branch=main)](https://github.com/dfed/swift-async-queue/actions?query=workflow%3ACI+branch%3Amain)
[![Swift Package Manager compatible](https://img.shields.io/badge/SPM-compatible-4BC51D.svg?style=flat)](https://github.com/apple/swift-package-manager)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we get this from the new swift package index badges below

@dfed dfed marked this pull request as ready for review January 11, 2024 02:58
@dfed
Copy link
Owner Author

dfed commented Jan 11, 2024

Going to merge this through without waiting for approval since we're just adding explicit support for platforms we were already supporting.

@dfed dfed merged commit 2ae35d8 into main Jan 11, 2024
@dfed dfed deleted the dfed--more-platforms branch January 11, 2024 02:59
@dfed
Copy link
Owner Author

dfed commented Jan 11, 2024

As always, happy to address feedback post-merge 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants