Adopt Swift 5.9 #22
Merged
Adopt Swift 5.9 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 936 921 -15
=========================================
- Hits 936 921 -15
|
bachand
approved these changes
Nov 29, 2023
| s.authors = 'Dan Federman' | ||
| s.source = { :git => 'https://github.com/dfed/swift-async-queue.git', :tag => s.version } | ||
| s.swift_version = '5.8' | ||
| s.swift_version = '5.9' |
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version: 5.8 | |||
| // swift-tools-version: 5.9 | |||
| // Continuation will be captured during stream creation, so it is safe to force unwrap here. | ||
| // If this force-unwrap fails, something is fundamentally broken in the Swift runtime. | ||
| taskStreamContinuation = capturedTaskStreamContinuation! | ||
| let (taskStream, taskStreamContinuation) = AsyncStream<ActorTask>.makeStream() |
| typhoeus (~> 1.0) | ||
| cocoapods-deintegrate (1.0.5) | ||
| cocoapods-downloader (1.6.3) | ||
| cocoapods-downloader (2.1) |
Collaborator
There was a problem hiding this comment.
This is a major version update. I am commenting so that this stands out.
Owner
Author
There was a problem hiding this comment.
This is due to the cocoapods version update. Doesn't affect anyone downstream.
| run: sudo xcode-select --switch /Applications/Xcode_14.3.1.app/Contents/Developer | ||
| - name: Build and Test Framework | ||
| run: xcrun swift test -c release -Xswiftc -enable-testing | ||
| run: bundle exec pod lib lint --verbose --fail-fast --swift-version=5.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Swift 5.9 introduces new API that allow us to remove our force unwraps!