Skip to content

Conversation

@dfed
Copy link
Owner

@dfed dfed commented Apr 9, 2023

This PR:

  1. Bumps our Swift version to 5.8 in the Package.swift to enable adopting enableUpcomingFeature
  2. Adopt fulfillment(of:timeout:) as waitForExpectations(timeout:) is deprecated in an async context
  3. Bumps Xcode version to 14.3.0
  4. Update macOS version to v13
  5. Updates our ruby version to work with macOS 13 CI

This PR will fail CI until ruby/setup-ruby#500 is resolved

@dfed dfed changed the title Bump tooling Bump Xcode Apr 9, 2023
@dfed dfed force-pushed the dfed--xcode-bump branch from 281cd81 to 4849beb Compare April 9, 2023 03:44
@dfed dfed force-pushed the dfed--xcode-bump branch 6 times, most recently from 0fc13a4 to 1983c2d Compare April 24, 2023 20:57
@dfed dfed force-pushed the dfed--xcode-bump branch from 1983c2d to 068e211 Compare April 24, 2023 21:04
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #16 (b9584ff) into main (63c36d7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          933       936    +3     
=========================================
+ Hits           933       936    +3     
Impacted Files Coverage Δ
Tests/AsyncQueueTests/ActorQueueTests.swift 100.00% <100.00%> (ø)
Tests/AsyncQueueTests/FIFOQueueTests.swift 100.00% <100.00%> (ø)
Tests/AsyncQueueTests/MainActorQueueTests.swift 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@dfed dfed force-pushed the dfed--xcode-bump branch from 29e817f to b9584ff Compare April 24, 2023 21:30
Comment on lines -14 to -16
- uses: ruby/setup-ruby@v1
with:
ruby-version: '2.7.6'
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we no longer need these lines because we're using a built-in ruby version rather than a custom one.

@dfed dfed requested review from bachand and omv-libs April 24, 2023 21:38
@dfed dfed marked this pull request as ready for review April 24, 2023 21:38
Copy link
Collaborator

@omv-libs omv-libs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@dfed dfed merged commit a232ddb into main Apr 25, 2023
@dfed dfed deleted the dfed--xcode-bump branch April 25, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants