async -> enqueue. await -> enqueueAndWait #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
force-pushed
the
dfed--async-await-rename
branch
from
2b8f252 to
3454ea6
Compare
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 752 752
=========================================
Hits 752 752
|
omv-libs
approved these changes
Feb 14, 2023
Collaborator
omv-libs
left a comment
omv-libs
left a comment
There was a problem hiding this comment.
I like this naming better. The prior version had too much baggage from the other APIs that use the same names.
bachand
reviewed
Feb 21, 2023
Collaborator
bachand
left a comment
bachand
left a comment
There was a problem hiding this comment.
Nice. I agree it's good to pick unique names that don't overlap with Swift language names.
| // MARK: Public | ||
|
|
||
| /// Sets the actor context within which each `async` and `await`ed task will execute. | ||
| /// Sets the actor context within which each `enqueue` and `enqueueAndWait` task will execute. |
Collaborator
There was a problem hiding this comment.
"enqueue and enqueueAndWait" -> "enqueueed and enqueueAndWaited"?
| /// The scheduled task will not execute until all prior tasks – including suspended tasks – have completed. | ||
| /// - Parameter task: The task to enqueue. | ||
| public func async(_ task: @escaping @Sendable () async -> Void) { | ||
| public func enqueue(_ task: @escaping @Sendable () async -> Void) { |
Collaborator
There was a problem hiding this comment.
Do we need to edit this await in this line?
| systemUnderTest = FIFOQueue() | ||
| } | ||
|
|
||
| // MARK: Behavior Tests |
Collaborator
There was a problem hiding this comment.
There are at least a couple places in the file like this that we should clean up.
dfed
added a commit
that referenced
this pull request
Feb 21, 2023
Owner
Author
|
Pushed feedback up into #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10